Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test CI #1131

Closed
wants to merge 28 commits into from
Closed

Test CI #1131

wants to merge 28 commits into from

Conversation

hsinfan1996
Copy link
Contributor

Why CI is failing on macOS during unit tests but not on Ubuntu?

@coveralls
Copy link

coveralls commented Oct 26, 2023

Pull Request Test Coverage Report for Build 6791082024

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4089 unchanged lines in 65 files lost coverage.
  • Overall coverage decreased (-64.8%) to 32.557%

Files with Coverage Reduction New Missed Lines %
pyccl/baryons/baryons_base.py 1 88.89%
pyccl/emulators/emu_base.py 2 81.82%
pyccl/halos/concentration/constant.py 4 71.43%
pyccl/halos/concentration/klypin11.py 4 66.67%
pyccl/halos/concentration/duffy08.py 6 60.0%
pyccl/halos/hmfunc/jenkins01.py 6 62.5%
pyccl/halos/hmfunc/press74.py 6 60.0%
pyccl/halos/hmfunc/angulo12.py 7 58.82%
pyccl/power.py 8 84.62%
pyccl/halos/concentration/bhattacharya13.py 9 50.0%
Totals Coverage Status
Change from base Build 6769057346: -64.8%
Covered Lines: 2054
Relevant Lines: 6309

💛 - Coveralls

@carlosggarcia
Copy link
Contributor

Hi @hsinfan1996. As a workaround, I increased the tolerance in #869 (see this commit: 2b323ea). With it both ubuntu and mac tests passed.

@hsinfan1996
Copy link
Contributor Author

Hi @hsinfan1996. As a workaround, I increased the tolerance in #869 (see this commit: 2b323ea). With it both ubuntu and mac tests passed.

Thanks. Yes, I think for now increasing the tolerance is the only way.

@damonge
Copy link
Collaborator

damonge commented Nov 6, 2023

Just so we're clear, what is the issue exactly? Is it that mac uses a different gsl or something like that compared to python on GHA?

@hsinfan1996
Copy link
Contributor Author

hsinfan1996 commented Nov 6, 2023

I still don't know caused the tests on macOS to fail. Amongst the packages common to the two platforms, the differences I can spot are the compilers and libgfortran-related packages. macOS uses libgfortran-devel_osx-64=12.2.0 while Ubuntu uses libgfortran5=13.2.0.

@damonge
Copy link
Collaborator

damonge commented Nov 6, 2023

Oh well... I'd be happy to just raise the tolerance and add a comment documented that this is because of mac on GHA (in case we can bring it back down in the future)

@hsinfan1996 hsinfan1996 closed this Nov 7, 2023
@hsinfan1996 hsinfan1996 deleted the test_CI branch November 7, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants